Eliminate need for creds #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansavvy
commented
Jul 14, 2024
… cansavvy-patch-1
… cansavvy-patch-1
cansavvy
commented
Jul 15, 2024
|
Next step is to make sure OTTR can actually run with this docker image as is. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this existed before 3 years ago but it does now and adds a layer of encryption to the secret we need. I still will have it deleted as an extra safety thing. It was being deleted as originally written so most docker images are fine. But this way we'll have it deleted, encrypted, and maybe idk see if we can incorporate another layer of security I haven't thought of yet.New strategy. Found a way we don't need creds at all. Much simpler much safer.