Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accent debugging to spell check #27

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Add accent debugging to spell check #27

merged 2 commits into from
Jan 31, 2024

Conversation

avahoffman
Copy link
Contributor

@avahoffman avahoffman commented Jan 31, 2024 •
edited
Loading

Was getting some confusing errors when adding words with accents to dictionary.txt. It wouldn't run, and I wasn't sure why :)

> sp_errors <- spelling::spell_check_files(files, ignore = dictionary)
Error in chartr("’", "'", as.character(add_words)) : 
  invalid input multibyte string 22

In other words, "Diné" in the dictionary.txt file was causing the spell check to break. I needed to use html inside the Rmd file (e.g. Din&eacute;).

Added some messaging to try to make this easier to diagnose from the Actions log.

Works as expected when tested locally, but there could be some edge cases.

@avahoffman
Add accent debugging to spell check
d9bef15 
Was getting some confusing errors when adding words with accents to dictionary.txt. It wouldn't run, and I wasn't sure why :) 

In other words, "ó" in the dictionary.txt file was causing the spell check to break.

Added some messaging to try to make this easier to diagnose from the Actions log.
@avahoffman avahoffman mentioned this pull request Jan 31, 2024
Open
cansavvy
cansavvy approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this!!! I always super appreciate you just file PRs as soon as you find a problem!

@cansavvy cansavvy merged commit a3aa93d into main Jan 31, 2024
4 checks passed
@cansavvy cansavvy deleted the avahoffman-patch-1 branch January 31, 2024 23:02
@avahoffman
Copy link
Contributor Author

Mostly I know I'll forget otherwise 😂

@avahoffman avahoffman mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cansavvy cansavvy cansavvy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avahoffman @cansavvy