Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update report-maker.yml #33

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Update report-maker.yml #33

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1232c51
Update report-maker.yml
cansavvy Mar 15, 2024
4ac5e38
Restore github actions login tho
cansavvy Mar 15, 2024
c8b4e39
Apply suggestions from code review
cansavvy Mar 15, 2024
78b758c
Add time back
cansavvy Mar 15, 2024
70de7b9
Merge branch 'cansavvy/REVERT' of github.com:jhudsl/ottr-reports into…
cansavvy Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 6 additions & 35 deletions .github/workflows/report-maker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ on:
type: string
default: ${GITHUB_REF#refs/heads/}
jobs:
status-update:
error-check:
runs-on: ubuntu-latest
container:
image: jhudsl/base_ottr:main

steps:
- name: Declare report name
Expand Down Expand Up @@ -52,8 +54,6 @@ jobs:
issue-number: ${{ github.event.pull_request.number }}
comment-author: 'github-actions[bot]'
body-includes: ${{ steps.setup.outputs.error_name }}
direction: first
nth: 1

- name: Status update
uses: peter-evans/create-or-update-comment@v2
Expand All @@ -65,33 +65,6 @@ jobs:
_Comment updated at ${{ steps.build-components.outputs.time }} with changes from ${{ steps.build-components.outputs.commit_id }}_
edit-mode: replace

error-check:
runs-on: ubuntu-latest
container:
image: jhudsl/base_ottr:main

steps:
- name: Declare report name
id: setup
run: |
if ${{ contains(inputs.check_type, 'spelling') }} ;then
echo "error_name=spelling errors" >> $GITHUB_OUTPUT
echo "ignore_file=resources/dictionary.txt" >> $GITHUB_OUTPUT
elif ${{ contains(inputs.check_type, 'urls') }} ;then
echo "error_name=broken urls" >> $GITHUB_OUTPUT
echo "ignore_file=resources/ignore-urls.txt" >> $GITHUB_OUTPUT
elif ${{ contains(inputs.check_type, 'quiz_format') }} ;then
echo "error_name=quiz formatting errors" >> $GITHUB_OUTPUT
fi

- name: Build components of the spell check comment
id: build-components
run: |
branch_name='preview-${{ github.event.pull_request.number }}'
echo "time=$(date +'%Y-%m-%d')" >> $GITHUB_OUTPUT
echo "commit_id=$GITHUB_SHA" >> $GITHUB_OUTPUT
shell: bash

- name: Checkout
uses: actions/checkout@v3
with:
Expand All @@ -110,8 +83,8 @@ jobs:
id: file-path
run: |
branch_name='preview-${{ github.event.pull_request.number }}'
echo "time=$(date +'%Y-%m-%d-%T')" >> $GITHUB_OUTPUT
echo "link_to_ignore_file=https://github.com/${GITHUB_REPOSITORY}/edit/${{ inputs.branch_name }}/${{ steps.setup.outputs.ignore_file }}" >> $GITHUB_OUTPUT
echo "time=$(date +'%Y-%m-%d-%T')" >> $GITHUB_OUTPUT
echo "error_url=https://github.com/${GITHUB_REPOSITORY}/blob/$branch_name/${{ steps.check_results.outputs.report_path }}" >> $GITHUB_OUTPUT
shell: bash

Expand All @@ -121,10 +94,8 @@ jobs:
with:
issue-number: ${{ github.event.pull_request.number }}
comment-author: 'github-actions[bot]'
body-includes: ${{ steps.setup.outputs.error_name }}' is currently being re-run'
direction: first
nth: 1

body-includes: ${{ steps.setup.outputs.error_name }}

- name: Say check is incomplete
if: steps.check_results.outcome == 'failure'
uses: peter-evans/create-or-update-comment@v2
Expand Down
Loading