Fix windows zip problem in vignette #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansavvy
changed the title
|
Ugh. Windows is still failing. I thought I had it on that last one. |
cansavvy
changed the title
|
I've ran out of ideas on how to fix this right now. Will return to it later. |
|
Going to retry this one more time now that the zip file doesn't have that weird folder (jhudsl/OTTR_Template#200) |
|
Nope: |
|
But alternatively I may just get rid of that coursera folder because we don't really need it. |
This was referenced Sep 20, 2021
|
Abandoning this strategy for another solution: #56 This PR is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears
rprojrootdoesn't always work consistently on windows operating systems. I think that is the problem behind #49.Edit: nope that wasn't the problem. Turns out Windows was having trouble unzipping the file to begin with and that had to do with its assumption that the example data zip file was a text file instead of a zip file like it is. So this is fixed by using
mode = "wb"upon downloading withdownload.file().