Initial refactor in preparing for WASM #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
force-pushed
the
jhugman/wasm/typescript-template-variations
branch
from
bce7ac4 to
87d3094
Compare
jhugman
force-pushed
the
jhugman/wasm/typescript-template-variations
branch
from
31e96a3 to
2e63119
Compare
zzorba
approved these changes
Dec 8, 2024
jhugman
force-pushed
the
jhugman/wasm/typescript-template-variations
branch
from
2e63119 to
b6d8abe
Compare
jhugman
force-pushed
the
jhugman/wasm/typescript-template-variations
branch
from
b6d8abe to
b5c91d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a small number of things, which makes it O(n * m).
Principally, it is to make room for the WASM bindings generator, with a
--flavorABI Flavor to switch between them.This necessitated quite a large refactor. Most of this is mechanical; a lot of changes are files moving and
usestatements being updated.The upshot of this PR is that we now have a
--flavor wasmflag in thextask run, which runs the typescript tests usingtsx/nodejs.The ReactNative bindings generator calls into a newly refactored
get_typescriptmodule which accepts a flavor.Anticipating that this is not the last time we'll add a switch like flavor, this is contained in a
SwitchesArgstruct.