Use version released to Cocoapods and npm #184
Conversation
jhugman
force-pushed
the
jhugman/post-initial-release
branch
from
f2f38fb to
b9786c1
Compare
jhugman
force-pushed
the
jhugman/post-initial-release
branch
from
b9786c1 to
74afbb7
Compare
jhugman
force-pushed
the
jhugman/post-initial-release
branch
from
74afbb7 to
5789a22
Compare
jhugman
force-pushed
the
jhugman/post-initial-release
branch
from
5789a22 to
d00dce3
Compare
| @@ -32,6 +32,7 @@ Pod::Spec.new do |s| | |||
| {%- let bindings = self.relative_to(root, dir) -%} | |||
| s.source_files = "{{ ios }}/**/*.{h,m,mm}", "{{ codegen }}/**/*.{h,m,mm}", "{{ tm }}/**/*.{hpp,cpp,c,h}", "{{ bindings }}/**/*.{hpp,cpp,c,h}" | |||
| s.vendored_frameworks = "{{ framework }}" | |||
| s.dependency "uniffi-bindgen-react-native", "{{ self.config.project.ubrn_version() }}" | |||
There was a problem hiding this comment.
I was briefly considering whether we should do something to support a local development flow where the pod is loaded from node_modules. However, I guess it's a rare use case and most likely not worth the hassle.
There was a problem hiding this comment.
If local development means: local development of ubrn, I spent a bunch of time yesterday trying to get the local development flow going.
Where I ended up was: getting the tests to comment out this line.
If local development means: local development of the subject rn-rust library, I wasn't really concerned about that, given that it's only adding the cpp/include/*.h files from ubrn, which—to a first approximation—don't really change. That and caching in a the Pods directory, means that it's as local as any other dependency.
There was a problem hiding this comment.
I kind of meant a mix of these two. I'm sometimes testing ubrn from a SHA against react-native-matrix-sdk. But it's exotic enough a use case that I can just make the small changes locally myself. So I think this is fine. 👍
Follow up to #166, now that has been released.
Once this is landed, we should:
We need to do a release now because:
uniffi-bindgen-react-native.