Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make first run more informative while compiling #185

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

jhugman
Copy link
Owner

@jhugman jhugman commented Dec 9, 2024

Fixes #181

According to The Big O of Code Reviews, this is a O(n) change.

This uses the "naive" solution suggested by @kraenhansen—it just detects the absence of the target directory.

I added the --quiet flag sometime ago because the default cargo output of the ubrn was getting to be annoying. Hopefully this is a reasonable compromise.

@jhugman jhugman requested a review from Johennes December 9, 2024 20:44
@Johennes
Copy link
Collaborator

:shipit:

@jhugman jhugman merged commit 923e1ea into main Dec 10, 2024
17 checks passed
@jhugman jhugman deleted the jhugman/181-less-quiet-on-first-run branch December 10, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Less silence from the CLI when ran the first time
2 participants