Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter permit #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

patrocc6
Copy link

Fixes parameter permit for multi-select inputs and multiple inputs to a single scope.

Fixes parameter permit for  multi-select inputs and multiple inputs to a single scope.
@edwardmp
Copy link
Contributor

edwardmp commented Dec 3, 2016

Thanks, noticed this issue recently while using such params in the past did actually work.
Edit: doesn't work in my case, I still get 'Unpermitted parameter'. But my issue more resembles #114 than your case so I will post this issue there too.

Strange as
permissible_filter_params contains ["sorted_by", "with_card_id", "with_company_id", "with_month_year", "with_numberplate_id"]
But still I get 'Unpermitted parameter: with_month_year'.
With_month_year is a hash with two items: month & year.

@JSanderbeck
Copy link

Ran into this one today... Trying to do a date range and get the Unpermitted Parameter...

@edwardmp
Copy link
Contributor

@JSanderbeck did you install the gem using this github pull request as a source to see if this solves your issue?

@JSanderbeck
Copy link

JSanderbeck commented Dec 20, 2016

No, I did not... I will try that... Never pulled from a git source... Do I just specify the master or the branch I want to test?

@JSanderbeck
Copy link

Ok. Manually updated file and this fix works for my problem. Just waiting for the merge so I can pull again...

Copy link

@JSanderbeck JSanderbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to fix the issue with the Invalid Parameter. Tested with date ranges and they pass through correctly.

@edwardmp
Copy link
Contributor

edwardmp commented Dec 27, 2016

@JSanderbeck that's great to hear.

If you didn't know, you could just use pull request #115 in your Gemfile like this:
gem 'filterrific', git: 'https://github.com/ayaman/filterrific.git'

@JSanderbeck
Copy link

I did the pull like you recommended and it worked on one of my development machines but not the other. It pulls the Master branch but the patched file is not there. Any ideas why?

John

jayhardee9 pushed a commit to bmic-development/sparc-request that referenced this pull request Feb 16, 2017
jayhardee9 pushed a commit to bmic-development/sparc-request that referenced this pull request Feb 21, 2017
@usamagoldev
Copy link

Fixes parameter permit for multi-select inputs and multiple inputs to a single scope is fixed by pulling request by
If you didn't know, you could just use pull request #115 in your Gemfile like this:
gem 'filterrific', git: 'https://github.com/ayaman/filterrific.git'
after this multi select params permit is fixed but single select params not working

wtholt pushed a commit to bmic-development/sparc-request that referenced this pull request Feb 24, 2017
@usamagoldev
Copy link

i'm using this gem 'filterrific', git: 'https://github.com/ayaman/filterrific.git' in gem file and fixing strong params in controller in reference to this => Fix strong params usage in Dashboard::ProtocolsController. Use a fork…
… of filterrific gem until bug is fixed.
but nothing is working except multiple params for single scope

wtholt pushed a commit to bmic-development/sparc-request that referenced this pull request Mar 2, 2017
wtholt pushed a commit to bmic-development/sparc-request that referenced this pull request Mar 3, 2017
wtholt pushed a commit to bmic-development/sparc-request that referenced this pull request Mar 8, 2017
wtholt pushed a commit to bmic-development/sparc-request that referenced this pull request Mar 15, 2017
wtholt pushed a commit to bmic-development/sparc-request that referenced this pull request Mar 16, 2017
wtholt pushed a commit to bmic-development/sparc-request that referenced this pull request Mar 17, 2017
wtholt pushed a commit to bmic-development/sparc-request that referenced this pull request Mar 21, 2017
wtholt pushed a commit to bmic-development/sparc-request that referenced this pull request Mar 24, 2017
wtholt pushed a commit to bmic-development/sparc-request that referenced this pull request Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants