-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parameter permit #116
base: master
Are you sure you want to change the base?
Fix parameter permit #116
Conversation
Fixes parameter permit for multi-select inputs and multiple inputs to a single scope.
Thanks, noticed this issue recently while using such params in the past did actually work. Strange as |
Ran into this one today... Trying to do a date range and get the Unpermitted Parameter... |
@JSanderbeck did you install the gem using this github pull request as a source to see if this solves your issue? |
No, I did not... I will try that... Never pulled from a git source... Do I just specify the master or the branch I want to test? |
Ok. Manually updated file and this fix works for my problem. Just waiting for the merge so I can pull again... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to fix the issue with the Invalid Parameter. Tested with date ranges and they pass through correctly.
@JSanderbeck that's great to hear. If you didn't know, you could just use pull request #115 in your Gemfile like this: |
I did the pull like you recommended and it worked on one of my development machines but not the other. It pulls the Master branch but the patched file is not there. Any ideas why? John |
… of filterrific gem until bug is fixed. See jhund/filterrific#116
… of filterrific gem until bug is fixed. See jhund/filterrific#116
Fixes parameter permit for multi-select inputs and multiple inputs to a single scope is fixed by pulling request by |
… of filterrific gem until bug is fixed. See jhund/filterrific#116
i'm using this gem 'filterrific', git: 'https://github.com/ayaman/filterrific.git' in gem file and fixing strong params in controller in reference to this => Fix strong params usage in Dashboard::ProtocolsController. Use a fork… |
… of filterrific gem until bug is fixed. See jhund/filterrific#116
… of filterrific gem until bug is fixed. See jhund/filterrific#116
… of filterrific gem until bug is fixed. See jhund/filterrific#116
… of filterrific gem until bug is fixed. See jhund/filterrific#116
… of filterrific gem until bug is fixed. See jhund/filterrific#116
… of filterrific gem until bug is fixed. See jhund/filterrific#116
… of filterrific gem until bug is fixed. See jhund/filterrific#116
… of filterrific gem until bug is fixed. See jhund/filterrific#116
… of filterrific gem until bug is fixed. See jhund/filterrific#116
Fixes parameter permit for multi-select inputs and multiple inputs to a single scope.