-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope with arity 0 and enum requests compatible #62
Open
hachpai
wants to merge
42
commits into
jhund:master
Choose a base branch
from
hachpai:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still this issue with scope methods arity... @jhund what's your mind about that? |
Updated patch version for ruby
updated patch and readme
join concatenates array elements to create a string with the optional specified separator. Unfortunately, the resulting string is assumed not HTML-safe, and so Rails escapes it to be safe. Rails offers a better alternative, safe_join, that will concatenate elements while retaining each element’s HTML-safety and returning an HTML-safe string.
Turbolinks 5 compatibility
Add Ruby 2.3.1 into Travis CI
Fix stringify_keys! Rails 5 deprication warning
Change array join to safe_join
Don't parse a hypen (-) as an int, also allow 0
…n tests: Use Gemfile instead of .gemspect
…ot testing for it any more.
…ers/assets.rb for all versions of Rails.
Hi! Is there more work to be done to merge this one? Happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I really wanted to use my enum-styled queries and 0-parameters scope. I've adapted filterriffic in a way to afford that.
As arity for scope and enums doesn't work as expected I use the ArgumentError exception.