Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a more reliable method of determining controller,action #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lastobelus
Copy link

fixes View Specs

@jhund
Copy link
Owner

jhund commented Dec 1, 2015

@lastobelus I'm curious to learn how #request.path_parameters[:controller] is more reliable than #controller_name. What's the difference between the two? Is your concern that #controller_name doesn't return namespaces? What if we use #controller_path instead?

Then "OneModule::TwoModule::NeatController" would result in "one_module/two_module/neat" instead of just "neat".

@lastobelus
Copy link
Author

@jhund this was a while ago -- as I recall #controller_name was actually not even defined in view specs. Have you tried this with view specs, as a opposed to integration or request specs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants