Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/optimize course fetch #967

Merged
merged 11 commits into from
Mar 5, 2023
Merged

Feature/optimize course fetch #967

merged 11 commits into from
Mar 5, 2023

Conversation

JJamesWWang
Copy link
Member

@JJamesWWang JJamesWWang commented Mar 4, 2023 •
edited
Loading

Description

  • Optimizes reactions by getting all of a student's reactions at once
  • Marginally optimizes serializing sections by grouping together offerings
  • Adds the migration to remove school as a db_index
  • Changes search limit to 6 from 8 for basic search (advanced search stays at 8).
  • Fixes an issue with advanced search not paginating

The issue with the CourseModal query is that you have to filter a Course's sections by semester, and I can't figure out a way to group the queries all together.

Change Log

@JJamesWWang JJamesWWang marked this pull request as ready for review March 4, 2023 06:06
@JJamesWWang JJamesWWang merged commit 43306a1 into jhuopensource:develop Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiaqiWang18 JiaqiWang18 JiaqiWang18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JJamesWWang @JiaqiWang18