Search/Migration:removed 2017-2021 semesters to improve search speeds #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jyang0403 So far looks good, you can request a review from James and I when you are ready to merge |
JiaqiWang18
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
The migration looks good! I am just wondering about the load on the database of deleting multiple semesters at once since there are multiple levels of cascade relationships here. Deleting the Semester will also delete the Sections which then will delete the Offerings. @JJamesWWang what is your take on this?
|
I think it'll be fine; it's roughly O(n) |
|
You may want to remove the old semesters from the parser too by the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing all older semesters (2017-2021) to improve course search speeds using a new data migration.
Change Log
Created a new migration file (0042) in timetables/migrations.