Unexpected select() behavior in version 1.17.1

[rzam]

There seems to be some weird behavior in version 1.17.1 when combining multiple nested attribute selectors.

Minimal working example:

Document document = Jsoup.parse("""
    <div id="parent">
        <span class="child"></span>
        <span class="child"></span>
        <span class="child"></span>
    </div>
""");

System.out.println(document.select("[class*=\"child\"]").size()); // 3
System.out.println(document.select("#parent [class*=\"child\"]").size()); // 3
System.out.println(document.select("#parent [class*=\"child\"], .some-other-selector").size()); // 3
System.out.println(document.select("#parent [class*=\"child\"], .some-other-selector .nested").size()); // 0

The first three selects all correctly find 3 nodes, while the last one doesn't seem to find anything.

The code above works correctly (all four selects find 3 nodes) on version 1.16.2.

Tested on OpenJDK 11, 17 and 21.

[jhy]

Thanks for the clear report. I am adding a EvaluatorDebug class to help show the structure of the parsed evaluator. The parses for the , or evaluator is binding at the wrong associativity, and creating a group AND which should be OR.

[class*=child]:
<AttributeWithValueContaining css="[class*=child]" cost="6"></AttributeWithValueContaining>

#parent [class*=child]:
<And css="#parent [class*=child]" cost="10">
  <Parent css="#parent " cost="4">
    <Id css="#parent" cost="2"></Id>
  </Parent>
  <AttributeWithValueContaining css="[class*=child]" cost="6"></AttributeWithValueContaining>
</And>

#parent [class*=child], .some-other-selector:
<And css="#parent [class*=child], .some-other-selector" cost="16">
  <Parent css="#parent " cost="4">
    <Id css="#parent" cost="2"></Id>
  </Parent>
  <Or css="[class*=child], .some-other-selector" cost="12">
    <AttributeWithValueContaining css="[class*=child]" cost="6"></AttributeWithValueContaining>
    <Class css=".some-other-selector" cost="6"></Class>
  </Or>
</And>

#parent [class*=child], .some-other-selector .nested:
<And css="#parent [class*=child], .some-other-selector .nested" cost="38">
  <Class css=".nested" cost="6"></Class>
  <Parent css="#parent [class*=child], .some-other-selector " cost="32">
    <And css="#parent [class*=child], .some-other-selector" cost="16">
      <Parent css="#parent " cost="4">
        <Id css="#parent" cost="2"></Id>
      </Parent>
      <Or css="[class*=child], .some-other-selector" cost="12">
        <AttributeWithValueContaining css="[class*=child]" cost="6"></AttributeWithValueContaining>
        <Class css=".some-other-selector" cost="6"></Class>
      </Or>
    </And>
  </Parent>
</And>

Without the space parent token, the OR binding is correct (but of course is a different selector):

#parent[class*=child], .some-other-selector .nested:
<Or css="#parent[class*=child], .some-other-selector .nested" cost="26">
  <And css="#parent[class*=child]" cost="8">
    <Id css="#parent" cost="2"></Id>
    <AttributeWithValueContaining css="[class*=child]" cost="6"></AttributeWithValueContaining>
  </And>
  <And css=".some-other-selector .nested" cost="18">
    <Class css=".nested" cost="6"></Class>
    <Parent css=".some-other-selector " cost="12">
      <Class css=".some-other-selector" cost="6"></Class>
    </Parent>
  </And>
</Or>

d126488 would be root.

[jhy]

Thanks, fixed!

Now correctly parses as:

#parent [class*=child], .some-other-selector .nested:
<Or css="#parent [class*=child], .some-other-selector .nested" cost="28">
  <And css="#parent [class*=child]" cost="10">
    <Parent css="#parent " cost="4">
      <Id css="#parent" cost="2"></Id>
    </Parent>
    <AttributeWithValueContaining css="[class*=child]" cost="6"></AttributeWithValueContaining>
  </And>
  <And css=".some-other-selector .nested" cost="18">
    <Class css=".nested" cost="6"></Class>
    <Parent css=".some-other-selector " cost="12">
      <Class css=".some-other-selector" cost="6"></Class>
    </Parent>
  </And>
</Or>