Merge pull request #206 from proflim/sungsu-dev

fix disk leakage
jiaaro · Aug 29, 2017 · 908c2e2 · 908c2e2
2 parents 098f6c9 + 57bc79e
commit 908c2e2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -63,3 +63,6 @@ Mike Mattozzi
 
 Marcio Mazza
  github: marciomazza
+
+Sungsu Lim
+ github: proflim
diff --git a/pydub/audio_segment.py b/pydub/audio_segment.py
@@ -508,12 +508,13 @@ def is_format(f):
  if p.returncode != 0:
  raise CouldntDecodeError("Decoding failed. ffmpeg returned error code: {0}\n\nOutput from ffmpeg/avlib:\n\n{1}".format(p.returncode, p_err))
 
- obj = cls._from_safe_wav(output)
-
- input_file.close()
- output.close()
- os.unlink(input_file.name)
- os.unlink(output.name)
+ try:
+ obj = cls._from_safe_wav(output)
+ finally:
+ input_file.close()
+ output.close()
+ os.unlink(input_file.name)
+ os.unlink(output.name)
 
  return obj