Merge pull request #280 from SergioRAgostinho/warnings

Suppress unclosed file descriptors' warnings

AUTHORS

@@ -69,3 +69,6 @@ Sungsu Lim
 
 Evandro Myller
  github: emyller
+
+Sérgio Agostinho
+ github: SergioRAgostinho

pydub/audio_segment.py

@@ -456,7 +456,9 @@ def is_format(f):
 
  if is_format("wav"):
  try:
- return cls._from_safe_wav(file)
+ obj = cls._from_safe_wav(file)
+ file.close()
+ return obj
  except:
  file.seek(0)
  elif is_format("raw") or is_format("pcm"):
@@ -469,7 +471,9 @@ def is_format(f):
  'channels': channels,
  'frame_width': channels * sample_width
  }
- return cls(data=file.read(), metadata=metadata)
+ obj = cls(data=file.read(), metadata=metadata)
+ file.close()
+ return obj
 
  input_file = NamedTemporaryFile(mode='wb', delete=False)
  try:
@@ -478,12 +482,14 @@ def is_format(f):
  input_file.flush()
  input_file.close()
  input_file = NamedTemporaryFile(mode='wb', delete=False, buffering=2**31-1)
+ file.close()
  file = open(orig_file, buffering=2**13-1, mode='rb')
  reader = file.read(2**31-1)
  while reader:
  input_file.write(reader)
  reader = file.read(2**31-1)
  input_file.flush()
+ file.close()
 
  output = NamedTemporaryFile(mode="rb", delete=False)
 
@@ -556,7 +562,9 @@ def from_raw(cls, file, **kwargs):
  def _from_safe_wav(cls, file):
  file = _fd_or_path_or_tempfile(file, 'rb', tempfile=False)
  file.seek(0)
- return cls(data=file)
+ obj = cls(data=file);
+ file.close()
+ return obj
 
  def export(self, out_f=None, format='mp3', codec=None, bitrate=None, parameters=None, tags=None, id3v2_version='4', cover=None):
  """
@@ -984,7 +992,9 @@ def append(self, seg, crossfade=100):
  output.write(seg2[crossfade:]._data)
 
  output.seek(0)
- return seg1._spawn(data=output)
+ obj = seg1._spawn(data=output)
+ output.close()
+ return obj
 
  def fade(self, to_gain=0, from_gain=0, start=None, end=None,
  duration=None):

test/test.py

@@ -627,10 +627,12 @@ def test_for_accidental_shortening(self):
  if sys.platform == 'win32':
  tmp_mp3_file.close()
 
- seg.export(tmp_mp3_file.name)
+ fd = seg.export(tmp_mp3_file.name)
+ fd.close()
 
  for i in range(3):
- AudioSegment.from_mp3(tmp_mp3_file.name).export(tmp_mp3_file.name, "mp3")
+ fd = AudioSegment.from_mp3(tmp_mp3_file.name).export(tmp_mp3_file.name, "mp3")
+ fd.close()
 
  tmp_seg = AudioSegment.from_mp3(tmp_mp3_file.name)
  self.assertFalse(len(tmp_seg) < len(seg))