Adds support for PEP 519 File Path protocol #252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
AudioSegment.from_file()
andAudioSegment.export()
to accept PathLike objects that represent file system paths, in addition to strings.Python 3.4 introduced pathlib to make handling filesystem paths easier. In Python 3.6, PEP 519 added support for a new protocol to many builtin methods, such as
open
, to allow objects to signal that they represent filesystem paths by returning astr
orbytes
from a__fspath()__
method.Explicit support for the protocol is necessary since the utility method
_fd_or_path_or_tempfile
is expected to return anything that isn't a string that represents a path unaltered, and thus explicitly checks for string.