fix: use flag in preflush to indicate whether reorder is required #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Rationale After the columnar encoding is supported for wal format, we should adapt such encoding in the wal write procedure. ## Detailed Changes Adapt the columnar encoding in the wal write procedure. And now, both rowwise and columnar encoding in the wal write procedure are supported, which to use depends on the configuration. ## Test Plan Existing tests. The compatibility tests have been designed as: - Write rowwise-encoded wal logs and restart the server to replay it - Write columnar-encoded wal logs and restart the server to replay it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Current we suggest new primary keys in preflush, and do a reorder in flush task.
There is no easy way for flush task to know if reorder if required.
Detailed Changes
coltoidentwhen build logical plan,identwill not normalize column name.Test Plan
Integration test.