Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syscall numbers for arm #4

Closed
wants to merge 2 commits into from
Closed

fix syscall numbers for arm #4

wants to merge 2 commits into from

Conversation

jepio
Copy link

@jepio jepio commented Sep 24, 2021

The previous numbers were not correct at all, and resulted in SIGILL being
raised when called on ARM. I took the updated values from:
https://chromium.googlesource.com/chromiumos/docs/+/master/constants/syscalls.md

The previous numbers were not correct at all, and resulted in SIGILL being
raised when called on ARM. I took the updated values from:
https://chromium.googlesource.com/chromiumos/docs/+/master/constants/syscalls.md
@jepio
Copy link
Author

jepio commented Sep 24, 2021

@JohnRusk @jiacfan don't know if you still look at this repo but it would be nice if you could merge and tag a release, that way I could bump the dependency in azcopy and make it work on ARMv7.

@JohnRusk
Copy link
Collaborator

@jepio, I'm not involved in this repro anymore, but @jiacfan or @zezha-msft may be able to help.

@jepio
Copy link
Author

jepio commented Sep 25, 2021

Thanks. For completeness I found out what was wrong: the original numbers refer to OABI, but everything out there uses EABI.

mohsha-msft added a commit to wastore/keyctl that referenced this pull request Sep 30, 2021
* Fix syscall numbers for arm

The previous numbers were not correct at all, and resulted in SIGILL being
raised when called on ARM. I took the updated values from:
https://chromium.googlesource.com/chromiumos/docs/+/master/constants/syscalls.md

* Add go.mod file

Co-authored-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@mohsha-msft
Copy link

Hey @jepio ,

We've forked this repo here
I've picked your changes and merged them here

@mohsha-msft
Copy link

Please let me know if there is any other dependency you wish to merge in order to make ARM work.

@jepio
Copy link
Author

jepio commented Oct 4, 2021

Hi @mohsha-msft,
Thanks, this is the only dependency that needed changing for ARM support. Since you're going to use the fork, I'm closing this PR then.

@jepio jepio closed this Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants