add -setProperty gwt compiler option #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to also include the new option in https://github.com/jiakuan/gwt-gradle-plugin/blob/main/doc/setup/Configuration%20References.md |
Good suggestion. Done |
jiakuan
reviewed
Oct 12, 2023
| @@ -51,6 +52,11 @@ protected void addArgs() { | |||
| argIfEnabled(getDisableGeneratingOnShards(), "-XdisableGeneratingOnShards"); | |||
|
|
|||
| argIfSet("-optimize", getOptimize()); | |||
|
|
|||
| for (String property: getSetProperties()) { | |||
There was a problem hiding this comment.
Is it possible that getSetProperties() is null?
There was a problem hiding this comment.
Looks like it's not as the setter won't be called if no such configuration exists
jiakuan
approved these changes
Oct 12, 2023
| @@ -51,6 +52,11 @@ protected void addArgs() { | |||
| argIfEnabled(getDisableGeneratingOnShards(), "-XdisableGeneratingOnShards"); | |||
|
|
|||
| argIfSet("-optimize", getOptimize()); | |||
|
|
|||
| for (String property: getSetProperties()) { | |||
There was a problem hiding this comment.
Looks like it's not as the setter won't be called if no such configuration exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the "-setProperty" parameter to the gwt compiler options. This partially addresses #4