Merge pull request #33 from Nessex/add-project-key-rate-limit

Add project key rate limit

sentry/resource_sentry_key.go

@@ -51,10 +51,12 @@ func resourceSentryKey() *schema.Resource {
 			},
 			"rate_limit_window": {
 				Type:     schema.TypeInt,
+				Optional: true,
 				Computed: true,
 			},
 			"rate_limit_count": {
 				Type:     schema.TypeInt,
+				Optional: true,
 				Computed: true,
 			},
 			"dsn_secret": {
@@ -80,6 +82,10 @@ func resourceSentryKeyCreate(d *schema.ResourceData, meta interface{}) error {
 	project := d.Get("project").(string)
 	params := &sentry.CreateProjectKeyParams{
 		Name: d.Get("name").(string),
+		RateLimit: &sentry.ProjectKeyRateLimit{
+			Window: d.Get("rate_limit_window").(int),
+			Count:  d.Get("rate_limit_count").(int),
+		},
 	}
 
 	key, _, err := client.ProjectKeys.Create(org, project, params)
@@ -88,6 +94,7 @@ func resourceSentryKeyCreate(d *schema.ResourceData, meta interface{}) error {
 	}
 
 	d.SetId(key.ID)
+
 	return resourceSentryKeyRead(d, meta)
 }
 
@@ -147,6 +154,10 @@ func resourceSentryKeyUpdate(d *schema.ResourceData, meta interface{}) error {
 	project := d.Get("project").(string)
 	params := &sentry.UpdateProjectKeyParams{
 		Name: d.Get("name").(string),
+		RateLimit: &sentry.ProjectKeyRateLimit{
+			Window: d.Get("rate_limit_window").(int),
+			Count:  d.Get("rate_limit_count").(int),
+		},
 	}
 
 	key, _, err := client.ProjectKeys.Update(org, project, id, params)

sentry/resource_sentry_key_test.go

@@ -46,6 +46,34 @@ func TestAccSentryKey_basic(t *testing.T) {
 	})
 }
 
+func TestAccSentryKey_RateLimit(t *testing.T) {
+	var key sentry.ProjectKey
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckSentryKeyDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccSentryKeyConfig,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckSentryKeyExists("sentry_key.test_key_rate_limit", &key),
+					resource.TestCheckResourceAttr("sentry_key.test_key_rate_limit", "rate_limit_window", "86400"),
+					resource.TestCheckResourceAttr("sentry_key.test_key_rate_limit", "rate_limit_count", "1000"),
+				),
+			},
+			{
+				Config: testAccSentryKeyUpdateConfig,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckSentryKeyExists("sentry_key.test_key_rate_limit", &key),
+					resource.TestCheckResourceAttr("sentry_key.test_key_rate_limit", "rate_limit_window", "100"),
+					resource.TestCheckResourceAttr("sentry_key.test_key_rate_limit", "rate_limit_count", "100"),
+				),
+			},
+		},
+	})
+}
+
 func testAccCheckSentryKeyDestroy(s *terraform.State) error {
 	client := testAccProvider.Meta().(*sentry.Client)
 
@@ -105,38 +133,54 @@ func testAccCheckSentryKeyExists(n string, projectKey *sentry.ProjectKey) resour
 
 var testAccSentryKeyConfig = fmt.Sprintf(`
 	resource "sentry_team" "test_team" {
-		organization = "%s"
+		organization = "%[1]s"
 		name = "Test team"
 	}
 
 	resource "sentry_project" "test_project" {
-		organization = "%s"
+		organization = "%[1]s"
 		team = "${sentry_team.test_team.id}"
 		name = "Test project"
 	}
 
 	resource "sentry_key" "test_key" {
-		organization = "%s"
+		organization = "%[1]s"
+		project = "${sentry_project.test_project.id}"
+		name = "Test key"
+	}
+
+	resource "sentry_key" "test_key_rate_limit" {
+		organization = "%[1]s"
 		project = "${sentry_project.test_project.id}"
 		name = "Test key"
+		rate_limit_window = 86400
+		rate_limit_count = 1000
 	}
-`, testOrganization, testOrganization, testOrganization)
+`, testOrganization)
 
 var testAccSentryKeyUpdateConfig = fmt.Sprintf(`
 	resource "sentry_team" "test_team" {
-		organization = "%s"
+		organization = "%[1]s"
 		name = "Test team"
 	}
 
 	resource "sentry_project" "test_project" {
-		organization = "%s"
+		organization = "%[1]s"
 		team = "${sentry_team.test_team.id}"
 		name = "Test project"
 	}
 
 	resource "sentry_key" "test_key" {
-		organization = "%s"
+		organization = "%[1]s"
 		project = "${sentry_project.test_project.id}"
 		name = "Test key changed"
 	}
-`, testOrganization, testOrganization, testOrganization)
+
+	resource "sentry_key" "test_key_rate_limit" {
+		organization = "%[1]s"
+		project = "${sentry_project.test_project.id}"
+		name = "Test key"
+		rate_limit_window = 100
+		rate_limit_count = 100
+	}
+`, testOrganization)