Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flowtype imports #696

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Fix flowtype imports #696

merged 2 commits into from
Mar 7, 2019

Conversation

flexxnn
Copy link
Contributor

@flexxnn flexxnn commented Mar 6, 2019

There is a problem with flowtype, when we are using

import type { foo, foo1 } from 'something'

foo and foo1 - will be any in inspector

And it works good, when types are imported as:

import { type foo, type foo1 } from 'something'

More information about this is here:
flow/flow-for-vscode#23

Copy link
Contributor

@stcherenkov stcherenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Also "identifier" is better than "declaration" not just because of bugs – with this approach we import both module and its' interface in one place.

@flexxnn flexxnn merged commit 4bfb9e9 into develop Mar 7, 2019
@flexxnn flexxnn deleted the hotfix/change-flowtype-imports branch March 7, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants