Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to make use of preprocess_priviliges helper function throughout code base #10

Closed
tjelvar-olsson opened this issue Oct 5, 2020 · 4 comments

Comments

@tjelvar-olsson
Copy link
Contributor

@jotelha - is my understanding correct that we could make more use of the helper function you implemented?

@tjelvar-olsson
Copy link
Contributor Author

It looks like there this is complete. However, since you are using this function in your code I think we should make the function public. I would also like to make the function name more explicit.

@jotelha how about renaming the function from _preprocess_priviliges to preprocess_query_base_uris?

@jotelha
Copy link
Member

jotelha commented Oct 13, 2020

Sure.

@tjelvar-olsson
Copy link
Contributor Author

I have implemented this in a backwards compatible way (i.e. the _preprocess_priviliges function is still in the code). I also added tests to the new preprocess_query_base_uris helper funciton. See eff0770

jotelha added a commit that referenced this issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants