Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install clang-format when building the docker image #6

Closed
deadbaed opened this issue May 23, 2020 · 2 comments · Fixed by #8
Closed

install clang-format when building the docker image #6

deadbaed opened this issue May 23, 2020 · 2 comments · Fixed by #8
Assignees
@jidicula
Labels
enhancement New feature or request

Comments

@deadbaed
Copy link

a little suggestion: install clang-format when building the docker image instead of installing it in entrypoint.sh.

installing it in the docker image would clean up the logs when using the action, at the moment there is the logs of clang-format installing
@jidicula jidicula self-assigned this May 23, 2020
@jidicula jidicula added the enhancement New feature or request label May 23, 2020
jidicula added a commit that referenced this issue May 23, 2020
@jidicula
[refactor][Dockerfile, entrypoint] Move pkg install to Dockerfile
e56e262 
**Why this change was necessary**
Installing within the docker image cleans up the logs when using the action.

**What this change does**
Moves `apt-get` commands from `entrypoint.sh` to `Dockerfile`.

**Additional context/notes/links**

Resolves: #6

Signed-off-by: jidicula <johanan.idicula@gmail.com>
@jidicula jidicula mentioned this issue May 23, 2020
Merged
@deadbaed
Copy link
Author

thanks!

@jidicula
Copy link
Owner

You're welcome! Thanks for your feedback!

jidicula added a commit that referenced this issue Jul 24, 2022
@jidicula
feat(ubuntu): Retire impish images
cbb072b 
Ubuntu Impish seems to be unsupported now and its Release files seem
to have been removed from the Ubuntu repositories.

> #6 1.390 E: The repository 'http://security.ubuntu.com/ubuntu impish-security Release' does not have a Release file.

See failures in https://github.com/jidicula/clang-format-action/runs/7485540299?check_suite_focus=true
@jidicula jidicula mentioned this issue Jul 24, 2022
Merged
jidicula added a commit that referenced this issue Jul 24, 2022
@jidicula
feat(ubuntu): Retire impish images
31d0b69 
Ubuntu Impish seems to be unsupported now and its Release files seem
to have been removed from the Ubuntu repositories.

> #6 1.390 E: The repository 'http://security.ubuntu.com/ubuntu impish-security Release' does not have a Release file.

See failures in https://github.com/jidicula/clang-format-action/runs/7485540299?check_suite_focus=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jidicula jidicula

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 6 jidicula/clang-format-action
2 participants
@deadbaed @jidicula