Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for customizing file extensions #79

Closed
Krzmbrzl opened this issue Jan 15, 2022 · 4 comments · Fixed by #125
Closed

Add option for customizing file extensions #79

Krzmbrzl opened this issue Jan 15, 2022 · 4 comments · Fixed by #125
Assignees
@jidicula
Labels
enhancement New feature or request

Comments

@Krzmbrzl
Copy link
Contributor

Now that the last issue is resolved, let me continue complaining :D

It would be nice if there was an additional option to this action that would allow to specify a set of file extensions for files to check. This could default to the current list of files, but gives the user more flexibility in terms of which files are to be checked by this action.
In that step it would probably also be nice to make the regex parsing used for finding the files with given extension case-insensitive, such that one does not have to worry about casing when specifying file extensions.
@jidicula jidicula added the enhancement New feature or request label Jan 15, 2022
@nmoinvaz
Copy link

nmoinvaz commented Jun 6, 2022 •
edited
Loading

This would be good for Objective-C which uses *.m and *.mm file extension for implementation files.

@jidicula jidicula self-assigned this Jun 6, 2022
@jidicula jidicula removed their assignment Oct 1, 2022
@bcaddy
Copy link
Contributor

bcaddy commented Nov 11, 2022

I would also like this. Our codebase uses a lot of CUDA and so we need to be able to format .cu and .hu files.

@bcaddy bcaddy mentioned this issue Nov 11, 2022
Merged
@scosman
Copy link

scosman commented Dec 17, 2022 •
edited
Loading

If anyone needs a fork adding .m files: https://github.com/scosman/clang-format-action . Note: this just statically adds .m, not option to customize as this issue requests.

Use this line in your yml: uses: scosman/clang-format-action@v0.1

But agree, official support for a custom extension list would be ideal!

@jidicula jidicula self-assigned this Dec 27, 2022
jidicula added a commit that referenced this issue Dec 27, 2022
@jidicula
feat(inputs): Add custom file regex Action input
e0e9507 
This change factors out the existing C/C++/Protobuf/CUDA regex into a variable
that's exposed to a new input in action.yml.

Resolves: #79
@jidicula jidicula mentioned this issue Dec 27, 2022
Merged
jidicula added a commit that referenced this issue Dec 27, 2022
@jidicula
feat(inputs): Add custom file regex Action input (#125)
134f658 
This change factors out the existing C/C++/Protobuf/CUDA regex into a variable
that's exposed to a new input in action.yml.

Resolves: #79
@jidicula
Copy link
Owner

Addressed in #125 🙂. Sorry that it took so long for me to get around to this! 4.10.0 release contains this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jidicula jidicula

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(inputs): Add custom file regex Action input jidicula/clang-format-action
5 participants
@scosman @nmoinvaz @Krzmbrzl @jidicula @bcaddy