Add support for clang-format-17 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jidicula
requested changes
Oct 8, 2023
There was a problem hiding this comment.
Thanks for submitting a PR! Could you split your changes in .github/workflows/clang-format-image.yml into a separate PR? Then I can approve and merge that and the new version image will start getting built and published to this repo's container registry, and this PR will be able to pull down that image and its tests will pass.
It's a bit convoluted but that's because I only allow image publish upon merge into main, not from PRs.
|
Ok @jidicula ! I'm creating the other Pull request right now 😉 |
jidicula
approved these changes
Oct 9, 2023
jidicula
added
the
hacktoberfest-accepted
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jidicula,
I am creating this Pull Request in relation with the issue #162 🙂 (and in the context of Hacktoberfest 2023).
I've inspired myself a lot from the Pull Requests you have linked in the issue description.
Currently, I am trying to run the script
test/test.shlike you mentioned in the CONTRIBUTING, but I am currently having the following error:and,
Maybe GitHub Actions will have the right setup, and not have this issue.
Until GitHub Actions gives me some results, I'll continue seeing if I can solve this issue on my end 😉