Skip to content

Commit

Permalink
bootstrap4: Removed invalid scope attribut in a tr element. (#691)
Browse files Browse the repository at this point in the history
bootstrap4: Removed invalid scope attribut in a tr element.

The problem was introduced in the WIP commit
7a0518d:

diff --git a/django_tables2/templates/django_tables2/bootstrap.html b/django_tables2/templates/django_tables2/bootstrap4.html
index feaf220..6cc1487 100644
--- a/django_tables2/templates/django_tables2/bootstrap.html
+++ b/django_tables2/templates/django_tables2/bootstrap4.html
@@ -25,7 +25,7 @@
                 <tbody {{ table.attrs.tbody.as_html }}>
                 {% for row in table.paginated_rows %}
                     {% block table.tbody.row %}
-                    <tr {{ row.attrs.as_html }}>
+                    <tr scope="row" {{ row.attrs.as_html }}>
                         {% for column, cell in row.items %}
                             <td {{ column.attrs.td.as_html }}>{% if column.localize == None %}{{ cell }}{% else %}{% if column.localize %}{{ cell|localize }}{% else %}{{ cell|unlocalize }}{% endif %}{% endif %}</td>
                         {% endfor %}
  • Loading branch information
vlt authored and jieter committed Sep 17, 2019
1 parent 84504c6 commit 8a41a53
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion django_tables2/templates/django_tables2/bootstrap4.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<tbody {{ table.attrs.tbody.as_html }}>
{% for row in table.paginated_rows %}
{% block table.tbody.row %}
<tr scope="row" {{ row.attrs.as_html }}>
<tr {{ row.attrs.as_html }}>
{% for column, cell in row.items %}
<td {{ column.attrs.td.as_html }}>{% if column.localize == None %}{{ cell }}{% else %}{% if column.localize %}{{ cell|localize }}{% else %}{{ cell|unlocalize }}{% endif %}{% endif %}</td>
{% endfor %}
Expand Down

0 comments on commit 8a41a53

Please sign in to comment.