Exporting tabes data with render_FOO column

[jacopsd]

When exporting a table using this approach
https://github.com/bradleyayers/django-tables2/blob/master/docs/pages/export.rst

... a field rendered with the render_FOO technique remains empty in the export.

[jieter]

Yes, you are right. Should be fixed (and tested).

[jieter]

Just pushed ecfe1c4, which adds this logic:

• If value_<name> is defined, use that method to get the value
• If render_<name> is defined, use that method to get the value
• Finally, use the column's value()-method.

please test branch master by installing it using the zip file github provides:

pip install -U https://github.com/bradleyayers/django-tables2/archive/master.zip

[jacopsd]

Works fine, except when unicode characters are in the table (running under python 2.7 & django 1.8.16)

In that case, following error occurs:

UnicodeDecodeError at
'ascii' codec can't decode byte 0xc3 in position 9: ordinal not in range(128)
Request Method: GET
Request URL: ?_export=xlsx
Django Version: 1.8.16
Exception Type: UnicodeDecodeError
Exception Value:
'ascii' codec can't decode byte 0xc3 in position 9: ordinal not in range(128)
Exception Location: /venv/lib/python2.7/site-packages/tablib/formats/_xlsx.py in dset_sheet, line 123
Python Executable: /venv/bin/python
Python Version: 2.7.10

[jieter]

Interesting.

I just added '毛泽东' to a table and tried exporting to csv, xls and xlsx. It just works. Can you provide some more detail? I tried with these versions:

django-tables2: current master.
python 2.7.10
Django==1.8.16
tablib==0.11.4

[jacopsd]

I had a European accent 'é' in one of the column titles and had the crash I described. D. 2017-06-28 21:46 GMT+02:00 Jan Pieter Waagmeester <notifications@github.com> :

…

Interesting. I just added '毛泽东' to a table and tried exporting to csv, xls and xlsx. It just works. Can you provide some more detail? I tried with these versions: django-tables2: current master. python 2.7.10 Django==1.8.16 tablib==0.11.4 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#458 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAM0XrCA_ot4Txp3pc5wLz4nd4_aNXilks5sIq1-gaJpZM4OFiCj> .

[jieter]

Ah, I didn't try adding unicode to the headers. This is a failing test:

def test_exporting_unicode_header():
    class Table(tables.Table):
        name = tables.Column(verbose_name='hé')

    exporter = TableExport('xls', Table([]))
    exporter.export()

[jieter]

Fixed in master (f44ebf2).

@jacopsd can you verify?

[jacopsd]

Verified, OK
Thank you for the fix!

[jieter]

thanks for checking, released 1.9.1.