Linkify

[jieter]

New API to transform any column into a link column:

class MyTable(tables.Table):
    id = tables.Column(linkify=True)
    country = tables.Column(linkify=True)
    start_date = tables.DateTimeColumn(linkify=True)

This allows using specialized columns (like DateColumn) with links, without falling back to LinkColumns, which do not know about dates.

You can also pass a dict, which will be passed thru to django.urls.reverse:

class MyTable(tables.Table):
    id = tables.Column(linkify=dict(viewname='person_detail', args=[A('pk')]))

Still TODO:

• decide if this is a good idea
• Add documentation
• and tests
• Check for regressions and fix

[dyve]

I don't like chaining. It confuses me (emphasis on I and me, this may be personal preference). More importantly, it tends to have magic rules. Most often "your chained function should always return type X unless [something special], then it's OK to do something else".

Wouldn't it be more pythonic to add an optional parameter url to any Column? If url is not None (and of course should be kwargs, then do exactly the same as you are now proposing to do with the linkify chain.

[dyve]

What happens if this does not exist or returns a non-string?

[dyve]

Code says: TypeError if it doesn't exist, no check for result I think. Might be worth giving it another glance and document a little more. Seems likely ppl will run into this when they just set link to True. Unlikely that get_absolute_url returns non-string. When it returns None, what happens?

[jieter]

If get_absolute_url does not exist -> error message: If linkify=True '{}' must have a method get_absolute_url.

The return value is used verbatim in the template, so I think that should be transparent enough?

[dyve]

I think I also saw some checks for url and uri attributes somewhere? Not i use anymore? Let me try and find them.

[jieter]

I renamed it to url to align with get_absolute_url, so uri should not occur anymore.

[dyve]

Is this in the docs?

[jieter]

outdated diff...

[jieter]

released 2.0.0a4