Make sure that pagination block is available in template regardless of pagination status #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f pagination status, so custom templates can make use of the block in any situation
Repository owner
deleted a comment from
coveralls
Sep 21, 2018
…emplates as well, not just tables.html
|
@apocalyptech looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates which extend
tables.htmldon't have access to thepaginationblock when there's only one page, which can pose a problem for templates which attempt to do some custom pagination coding.This fixes #621
Verified that tests still pass, and verified that this does the trick on my own app which was using a custom template to do just that, though I've not done further testing than that.