Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popping the extra_context of TemplateColumn #767

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Fix popping the extra_context of TemplateColumn #767

merged 1 commit into from
Sep 14, 2020

Conversation

bernhardmiller
Copy link
Contributor

Previously, The TemplateColumn's extra_context was never popped from the context. (two context.update, one context.pop)

@jieter jieter changed the title fix popping the extra_context of TemplateColumn Fix popping the extra_context of TemplateColumn Sep 14, 2020
"row_counter": kwargs["bound_row"].row_counter,
}
additional_context.update(self.extra_context)
with context.update(additional_context):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not know about the ability to use Context.update() as a context manager, nice!

@jieter jieter merged commit 99ee0ef into jieter:master Sep 14, 2020
@jieter
Copy link
Owner

jieter commented Sep 14, 2020

@bernhardmiller Merged, thanks!

@bernhardmiller bernhardmiller deleted the templatecolumn_context_fix branch September 16, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants