-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to specify executable .slate's which emit config #145
base: master
Are you sure you want to change the base?
Conversation
Bump, any news here? |
I believe the objective C way to do static methods is to use + instead of - in the method name. I would refactor your code to use an objective C method. Something like |
very interesting idea. i like it. +1 to @trishume though. But instead of changing that method what would be even better is if you could use |
Sorry I managed to miss these comments. It should be doable, I think ShellUtils will need a pretty drastic refactor. I'll probably need some eyes over the code, purely because my obj-c fu isn't great. Thanks for the feedback, I'll have a loko this week. |
This means that you can dynamically generate your config at launch time.
Hey guys, sorry for the long delay. I finally got time to look at this and would appreciate feedback. |
Relatedly, there's potentially a deadlock in ShellUtils +run. I'll get a patch out to you soon, it would be fairly hard to run into though. |
This means that you can dynamically generate your config at launch time.
My objective C fu is not great, so I'm very open to feedback on the code/don't mind refactoring.
Thanks for slate, it's awesome.