Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve geoHashesForPolygon split and filter #22

Closed
jillesvangurp opened this issue Jul 16, 2020 · 1 comment
Closed

improve geoHashesForPolygon split and filter #22

jillesvangurp opened this issue Jul 16, 2020 · 1 comment

Comments

@jillesvangurp
Copy link
Owner

We currently rely on polygonContains to look for geohash bboxes that have all 4 of their corners fully inside.

We should experiment with a variant that checks whether any of the polygon segments crosses any of the polygon segments.
jillesvangurp added a commit that referenced this issue May 20, 2021
@jillesvangurp
finally address #22 and include partially overlapping hash boxes for …
4d3d146 
…cover with polygons

also refactor API a bit to be more consistent with linear rings, polygons, etc.
@jillesvangurp jillesvangurp mentioned this issue May 20, 2021
Merged
@jillesvangurp
Copy link
Owner Author

Closed by #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jillesvangurp