fix clippy

jimexist · May 21, 2021 · 5c4d92d · 5c4d92d
1 parent a0b7526
commit 5c4d92d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/ballista/rust/core/src/serde/logical_plan/from_proto.rs b/ballista/rust/core/src/serde/logical_plan/from_proto.rs
@@ -1290,7 +1290,7 @@ impl TryFrom<protobuf::WindowFrameBound> for WindowFrameBound {
                 "Received a WindowFrameBound message with unknown WindowFrameBoundType {}",
                 bound.window_frame_bound_type
             ))
-        })?.into();
+        })?;
         match bound_type {
             protobuf::WindowFrameBoundType::CurrentRow => {
                 Ok(WindowFrameBound::CurrentRow)

diff --git a/datafusion/src/physical_plan/planner.rs b/datafusion/src/physical_plan/planner.rs
@@ -164,7 +164,7 @@ impl DefaultPhysicalPlanner {
                 Ok(Arc::new(WindowAggExec::try_new(
                     window_expr,
                     input_exec.clone(),
-                    input_schema.clone(),
+                    input_schema,
                 )?))
             }
             LogicalPlan::Aggregate {

diff --git a/datafusion/src/physical_plan/windows.rs b/datafusion/src/physical_plan/windows.rs
@@ -163,7 +163,7 @@ impl ExecutionPlan for WindowAggExec {
             1 => Ok(Arc::new(WindowAggExec::try_new(
                 self.window_expr.clone(),
                 children[0].clone(),
-                children[0].schema().clone(),
+                children[0].schema(),
             )?)),
             _ => Err(DataFusionError::Internal(
                 "WindowAggExec wrong number of children".to_owned(),

diff --git a/datafusion/src/sql/planner.rs b/datafusion/src/sql/planner.rs
@@ -678,7 +678,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
         select_exprs: &[Expr],
     ) -> Result<(LogicalPlan, Vec<Expr>)> {
         let plan = LogicalPlanBuilder::from(input)
-            .window(window_exprs.clone())?
+            .window(window_exprs)?
             .build()?;
         let select_exprs = select_exprs
             .iter()