update bindings to support node 14 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked it over, and it looks good. (And I verified that the test pass over here as well.) Thanks a ton for taking on finding out what the API changes were and working on adapting the wrapper! It looks like this PR is marked as in-progress. Do you have any other changes planned? |
|
Dear Jim, I was doing some additional testing on my end! Thank you for your review, and for maintaining the lib 😄 Best, Benjamin |
|
Cool! Merging! |
jimkang
approved these changes
May 3, 2021
|
All right. I added you to the contributor list, these changes have been published in 3.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In response to PR #12, I tried to update the faulty bindings.
I ran
make testandmake big-test, both turned to be OK 24/24.Let me know I can be of any help,
Best, Benjamin