Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #3: Update Annoy version #4

Merged
merged 1 commit into from
Jun 8, 2018
Merged

FIX #3: Update Annoy version #4

merged 1 commit into from
Jun 8, 2018

Conversation

mbuszka
Copy link
Contributor

@mbuszka mbuszka commented Jun 8, 2018

  • Update Annoy library to current master
  • Add Manhattan metric option to wrapper
  • getDistance now returns proper distance, not squared
  • fixed tests, added test for manhattan distance

@mbuszka
FIX #3: Update Annoy version
b6e5aa9 
- Update Annoy library to current master
- Add Manhattan metric option to wrapper
- getDistance now returns proper distance, not squared
- fixed tests, added test for manhattan distance
jimkang
jimkang approved these changes Jun 8, 2018
View reviewed changes
Copy link
Owner

@jimkang jimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your hard work! I'll try it out and merge if it seems fine.

kissrandom.h
@@ -0,0 +1,106 @@
#ifndef KISSRANDOM_H
#define KISSRANDOM_H

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Are there any obviously noticeable effects of using this instead of RandRandom?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice, but it's used upstream, so i thought we should use it as well to keep consistency. (Also they removed RandRandom)

@jimkang jimkang merged commit a5c80c3 into jimkang:master Jun 8, 2018
@jimkang
Copy link
Owner

jimkang commented Jun 8, 2018

Published in NPM as version 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimkang jimkang jimkang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbuszka @jimkang