Fix round number for Wednesday matches #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there might be a new issue with AFLW data that is causing all tests to fail at the moment :( I might have to refactor that part of the code before merging this in |
|
Ok made a commit (8fe62d2) that fixes the womens-stats error on Travis. If you merge master into your PR and resubmit it should be fine. Also, just to note, to get tests to run on your local machine you have to do the following code since we are using Sys.setenv(NOT_CRAN = "true")
devtools::check()Related to this issue that should be fixed soon in |
As with other recent bugs for footywire round number calculations, I'm a bit confused as to what changed regarding how weeks and weekdays are counted to cause this, but something moved Wednesdays from the beginning to the end of the round week by default. Changing the between filter to use Sunday and Tuesday as the limits makes the default round week Wednesday to Tuesday as intended.
|
Ok, rebased and pushed, and it looks like it's good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #95
As with other recent bugs for footywire round number calculations,
I'm a bit confused as to what changed regarding how weeks and
weekdays are counted to cause this, but something moved Wednesdays
from the beginning to the end of the round week by default.
Changing the between filter to use Sunday and Tuesday as the limits
makes the default round week Wednesday to Tuesday as intended.