Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Add interval before resending balance reduced notification #16

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Add interval before resending balance reduced notification #16

merged 7 commits into from
Jun 7, 2022

Conversation

jimmygchen
Copy link
Owner

Addresses #2:

  • to reduce false negatives - only send alert after balance reduced for 3 consecutive epochs
  • only resend alert after a certain amount of time has passed (default to 20 epochs)

@jimmygchen jimmygchen requested a review from yury-dubinin June 3, 2022 00:23
@jimmygchen jimmygchen self-assigned this Jun 3, 2022
@jimmygchen
Copy link
Owner Author

Hey @yury-dubinin
This is looking pretty solid now - I've had it running for a couple of days without much false negatives. Let me know if you have any comments before we merge this

@jimmygchen jimmygchen mentioned this pull request Jun 7, 2022
Merged
yury-dubinin
yury-dubinin approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@yury-dubinin yury-dubinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yury-dubinin yury-dubinin merged commit ae5ebd8 into main Jun 7, 2022
@jimmygchen jimmygchen deleted the balance-reduced-trigger branch June 11, 2022 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yury-dubinin yury-dubinin yury-dubinin approved these changes

Assignees

@jimmygchen jimmygchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmygchen @yury-dubinin