as file name is Blob in IE

[mmiklosik]

if i append File to FormData and after get filename

formdata.get("file").name

i get Blob

...
i found

if (!window.FormData || !window.FormData.prototype.keys) {
  var x = function(b, a, d) {
      if (2 > arguments.length)
        throw new TypeError(
          "2 arguments required, but only " + arguments.length + " present."
        );
      return a instanceof Blob
        ? [
            b + "",
            a,
            void 0 !== d
              ? d + ""
              : "File" === Object.prototype.toString.call(a).slice(8, -1)
                ? a.name
                : "Blob"
          ]
        : [b + "", a + ""];
    },

i print value of param a is [object File], but Object.prototype.toString.call(a) is [object Blob]

if return change to

return a instanceof Blob
        ? [
            b + "",
            a,
            void 0 !== d
              ? d + ""
              : a.name
          ]
        : [b + "", a + ""];

and i get real name

[jimmywarting]

Old ie don't have Symbol.toStringTag and the polyfill was therefore not able to change the Object.prototype.toString.call to return correct type of the polyfilled File constructor.

I changed the way it checks if it's a "File" so it return the correct filename.

Maybe cold have be fixed if the Symbol polyfill was included, but not sure. Could be nice to include since it contains toStringTag and entries which formdata also uses to be able to do [...fd] and for...of

[mmiklosik]

still doesn't work ( [object File].toString() is [object Blob] :( & i don't know why

it would by possible instead of this part

    return value instanceof Blob
      // normalize name and filename if adding an attachment
      ? [name + '', value, filename !== undefined
        ? filename + '' // Cast filename to string if 3th arg isn't undefined
        : type(value) === 'File' // if it's a File
          ? value.name // Use File.name
          : 'Blob'] // otherwise fallback to Blob

      // If no attachment, just cast the args to strings
      : [name + '', value + '']

give

    return value instanceof Blob
      // normalize name and filename if adding an attachment
      ? [name + '', value, filename !== undefined
        ? filename + '' // Cast filename to string if 3th arg isn't undefined
        : value.name // if object (File) have name prop
          ? value.name // Use File.name
          : 'Blob'] // otherwise fallback to Blob

      // If no attachment, just cast the args to strings
      : [name + '', value + '']

[jimmywarting]

Guess we could take the name property without checking if it's a file
Don't think it will do any harm

But i will change it to this:

    return value instanceof Blob
      // normalize name and filename if adding an attachment
      ? [name + '', value, filename !== undefined
        ? filename + '' // Cast filename to string if 3th arg isn't undefined
        : value.name || 'Blob'] // otherwise use File's name or fallback to Blob

      // If no attachment, just cast the args to strings
      : [name + '', value + '']

[mmiklosik]

nice, thanks

[jimmywarting]

or maybe not...

Trying this out in chrome yeilds file.name == ''

fd = new FormData()
fd.append('f', new File([], ''))
console.log([...fd][0][1])

[jimmywarting]

maybe need to check at least if it's a string
So...

    return value instanceof Blob
      // normalize name and filename if adding an attachment
      ? [name + '', value, filename !== undefined
        ? filename + '' // Cast filename to string if 3th arg isn't undefined
        : typeof value.name === 'string' // if object (File) have name prop
          ? value.name // Use File.name
          : 'Blob'] // otherwise fallback to Blob

[mmiklosik]

this solution

...
: typeof value.name === 'string'
...

it works in both chrome and ie, for me

[jimmywarting]

There u go, publish 3.0.9

[jimmywarting]

Curious doe...

still doesn't work ( [object File].toString() is [object Blob] :( & i don't know why

What did you do to make this happened? Would like a to build a test for this.
Guessing you tried to construct the file?

[jimmywarting]

Dose this fail to override toString in IE?

var blob = new Blob()

Object.defineProperties(blob, {
  toString: {
    value: function() {
      return '[object File]'
    }
  }
})

console.log(blob.toString())

[mmiklosik]

it finally works, thank you so much ;)

[mmiklosik]

about that toString() problem, i thing that problem IE
if i upload File is type object File but toString make him blob

[jimmywarting]

lol, tried it myself in browserstack so wierd

[mmiklosik]

sometimes, whole IE is weird :)