Update mocha-phantomjs-core to the latest version 🚀 #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.1.2 of mocha-phantomjs-core just got published.
The version 2.1.2 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of mocha-phantomjs-core.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 14 commits.
a45a21c
Remove slimerjs until it is fixed, tracking in #25
8294137
Merge pull request #36 from nvh/master
5c7451e
getColWith -> configureColWidth
c5b2206
ensure the viewport test always runs
2b64242
Add some example usages. Resolves #30 [ci skip]
a99c781
npm does not like relative paths apparently. Fixes #29
b1e16ca
release 2.1.0
9112813
Merge pull request #22 from ixaris/master
e7c718f
Wired viewport-size tests in core.tests.coffee
d6003d7
Update Function#bind polyfil to be up to spec
cb47d27
Added assertions. Test works on both SlimerJS and PhantomJS
dbb310a
Pull request feedback :
118eb8f
Added documentation to change supporting viewportSize configuration.
01ff148
Added callback for viewport modification - allowing tests for responsiveness.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴