-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade nearly-all dev deps #799
Conversation
@hipstersmoothie seems there is some issue with |
🚀 PR was released in v0.8.5 🚀 |
@hipstersmoothie I don't mean to complain too much, but the CHANGELOG.md seems to have associated this PR as well as #800 to @popinguy https://github.com/oliver-moran/jimp/blob/master/CHANGELOG.md#v085-fri-oct-18-2019 (The same on the |
What's Changing and Why
Upgrading dev deps, there should be no breaking changes to consumption
The only three dev deps were not updated were:
@types/yargs
- seemed to break some type checks on CLI when doing sots-node
- seemed to break some things in a build step when doing so, I know some tools rely on this via peer dep, so I assumed not upgrading for now would be best@types/log-symbols
- v3 turns into a shim type as v3 of the library added TS support https://github.com/sindresorhus/log-symbols/releases. However, v3 of the library also ups the required node version, which would mean a breaking change for jimp that I didn't want to introduce until more work on Uncaught ReferenceError: regeneratorRuntime is not defined #797I also had to run
xo --fix
to fix some things that were added/changed somewhere in the linting process when upgradingeslint
,prettier
, I'm unsureWhat else might be affected
This would drop support for any version of node > 8 for local dev
There seem to be new warnings for linting, but no errors
Published PR with canary version:
0.8.5-canary.799.447.0