feat: add faiss indexer #19
Conversation
cristianmtr
force-pushed
the
feat-faiss-indexer
branch
4 times, most recently
from
bd8ab70 to
9f7477e
Compare
cristianmtr
force-pushed
the
feat-faiss-indexer
branch
from
9f7477e to
6c6a5eb
Compare
cristianmtr
force-pushed
the
feat-faiss-indexer
branch
3 times, most recently
from
211f288 to
9727a47
Compare
| return | ||
|
|
||
| @requests(on='/search') | ||
| def query(self, docs: DocumentArray, parameters: Dict = None, *args, **kwargs): |
There was a problem hiding this comment.
I am not sure if it matches the signature but maybe add Optional to parameters type hint?
| normalize: bool = False, | ||
| nprobe: int = 1, | ||
| dump_path: Optional[str] = None, | ||
| traverse_path: str = 'r', |
There was a problem hiding this comment.
we have to agree if this is default_traversal_path or what, but we should be consistent. Also this should be a Union[str, List[str]]
There was a problem hiding this comment.
That's why we should actually have another class, Indexer to do this consistently.
I'll name it default_ for this
| return 0 | ||
|
|
||
| @requests(on='/fill_embedding') | ||
| def fill_embedding(self, query_da: DocumentArray, **kwargs): |
There was a problem hiding this comment.
this should be called docs as per any function of any executor that has an endpoint
cristianmtr
force-pushed
the
feat-faiss-indexer
branch
from
9727a47 to
9e57bc8
Compare
|
@JoanFM recheck |
| normalize: bool = False, | ||
| nprobe: int = 1, | ||
| dump_path: Optional[str] = None, | ||
| default_traversal_path: str = 'r', |
There was a problem hiding this comment.
ah yes, missed it
cristianmtr
force-pushed
the
feat-faiss-indexer
branch
from
9e57bc8 to
aec6337
Compare
What do you mean? There are integration tests and they are always run in the CI |
Part of jina-ai/serve#2560