-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice. Anyhow, dump
is required and vectors are currently not stored separately.
857d5e0
to
ddfa3b8
Compare
b601ed5
to
66f5404
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have both unit and integration tests?
t.replace(d.id.encode(), d.SerializeToString()) | ||
|
||
@requests(on='/delete') | ||
def delete(self, docs: DocumentArray, parameters: Dict = None, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typehint is not accurate, but actually it will never be None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
They are all under Integration tests are separated, since they need to import from across the repo (which you cannot do in the Dockerfile where we run the unit tests). Perhaps the problem here is that they are not just "unit" tests, since they are also tested with the Flow/ with dumping etc. |
Yes, there need to be unit tests without Flow |
There are |
741a938
to
cb31d84
Compare
part of jina-ai/serve#2560
lmdb (disk-based key-value storage) indexer
more info https://lmdb.readthedocs.io/en/release/
Performance metrics
compared with FileDBMSIndexer (the former BinaryPb):
Includes:
DBMSIndexer --> Indexer
QueryIndexer --> Searcher