Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

chore: add example CSV files #663

Merged
merged 8 commits into from
Jan 24, 2023
Merged

chore: add example CSV files #663

merged 8 commits into from
Jan 24, 2023

Conversation

LMMilliken
Copy link
Contributor

@LMMilliken LMMilliken commented Jan 23, 2023 •
edited
Loading

This pr adds a folder containing several CSV files that are suitable to be uploaded to the JAC as data for a finetuning run.
It is worth noting the the file image-text_or_image_example.csv is suitable for both text-image and image-image tasks as each row can be interpreted as either a image-text pair (suitable for text-image) or a image-label pair (suitable for image-image)

  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@LMMilliken LMMilliken requested a review from gmastrapas January 23, 2023 15:21
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@LMMilliken LMMilliken requested a review from guenthermi January 23, 2023 15:22
@LMMilliken
Copy link
Contributor Author

The mesh-mesh example wont work on JAC at the moment, as they are not using the latest version of core, which is needed to support pointnet++

gmastrapas
gmastrapas approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@gmastrapas gmastrapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename folder to data?

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@LMMilliken
Copy link
Contributor Author

Can you rename folder to data?

the name 'data' is in one of our gitignore files, i have renamed to example_data instead

guenthermi
guenthermi approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@guenthermi guenthermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmastrapas
Copy link
Member

Can you rename folder to data?

the name 'data' is in one of our gitignore files, i have renamed to example_data instead

datasets then? I really dislike _ names, especially in the root dir 🥲

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@LMMilliken LMMilliken merged commit c652373 into main Jan 24, 2023
@LMMilliken LMMilliken deleted the add-dummy-csvs branch January 24, 2023 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gmastrapas gmastrapas gmastrapas approved these changes

@guenthermi guenthermi guenthermi approved these changes

Assignees
No one assigned
Labels
size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LMMilliken @gmastrapas @guenthermi