Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

docs: add optimizer and query document score #697

Merged
merged 17 commits into from
Mar 21, 2023
Merged

docs: add optimizer and query document score #697

merged 17 commits into from
Mar 21, 2023

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Mar 20, 2023 •
edited
Loading

Since we're working on documentation restructuring, i only added these features into associated components (without optimization). The changes:

  1. layer-wise learning rate decay.
  2. query-document-score CSV preparation.
  3. CosineSimilarityLoss
  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@bwanglzu bwanglzu self-assigned this Mar 21, 2023
@bwanglzu bwanglzu marked this pull request as ready for review March 21, 2023 07:36
LMMilliken
LMMilliken suggested changes Mar 21, 2023
View reviewed changes
docs/advanced-topics/advanced-losses-optimizers-and-poolers.md Outdated Show resolved Hide resolved
docs/walkthrough/create-training-data.md Show resolved Hide resolved
docs/walkthrough/create-training-data.md Show resolved Hide resolved
docs/walkthrough/run-job.md Outdated Show resolved Hide resolved
bwanglzu and others added 2 commits March 21, 2023 09:11
@bwanglzu @LMMilliken
docs: improve wording
dd2c0e4 
Co-authored-by: Louis Milliken <58855099+LMMilliken@users.noreply.github.com>
@bwanglzu @LMMilliken
docs: improve wording
148a4c8 
Co-authored-by: Louis Milliken <58855099+LMMilliken@users.noreply.github.com>
LMMilliken
LMMilliken reviewed Mar 21, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@bwanglzu @LMMilliken
chore: update changelog
fe2ec00 
Co-authored-by: Louis Milliken <58855099+LMMilliken@users.noreply.github.com>
guenthermi
guenthermi reviewed Mar 21, 2023
View reviewed changes
docs/advanced-topics/advanced-losses-optimizers-and-poolers.md Outdated Show resolved Hide resolved
docs/advanced-topics/advanced-losses-optimizers-and-poolers.md Outdated Show resolved Hide resolved
docs/advanced-topics/advanced-losses-optimizers-and-poolers.md Outdated Show resolved Hide resolved
docs/advanced-topics/advanced-losses-optimizers-and-poolers.md Outdated Show resolved Hide resolved
docs/walkthrough/create-training-data.md Outdated Show resolved Hide resolved
docs/walkthrough/run-job.md Outdated Show resolved Hide resolved
docs/walkthrough/run-job.md Outdated Show resolved Hide resolved
guenthermi
guenthermi approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@guenthermi guenthermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only two small additional comments

docs/advanced-topics/advanced-losses-optimizers-and-poolers.md Outdated Show resolved Hide resolved
docs/walkthrough/create-training-data.md Outdated Show resolved Hide resolved
bwanglzu and others added 2 commits March 21, 2023 10:32
@bwanglzu @guenthermi
docs: improve tab naming for cosine similarity
d656ded 
Co-authored-by: Michael Günther <michael.guenther@jina.ai>
@bwanglzu @guenthermi
docs: improve wording
04c1de4 
Co-authored-by: Michael Günther <michael.guenther@jina.ai>
@github-actions
Copy link

📝 Docs are deployed on https://ft-docs-loss-llrd--jina-docs.netlify.app 🎉

scott-martens
scott-martens approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@scott-martens scott-martens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LMMilliken
LMMilliken approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@LMMilliken LMMilliken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bwanglzu bwanglzu merged commit fac4180 into main Mar 21, 2023
@bwanglzu bwanglzu deleted the docs-loss-llrd branch March 21, 2023 11:13
@bwanglzu bwanglzu mentioned this pull request Mar 29, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scott-martens scott-martens scott-martens approved these changes

@LMMilliken LMMilliken LMMilliken approved these changes

@guenthermi guenthermi guenthermi approved these changes

@gmastrapas gmastrapas Awaiting requested review from gmastrapas

Assignees

@bwanglzu bwanglzu

Labels
area/docs size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bwanglzu @guenthermi @LMMilliken @scott-martens