Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

refactor(tailor): improve interface #82

Merged
merged 12 commits into from
Oct 5, 2021
Merged

refactor(tailor): improve interface #82

merged 12 commits into from
Oct 5, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Oct 4, 2021

No description provided.

@bwanglzu
Copy link
Member

bwanglzu commented Oct 5, 2021

what has been done in this PR?

  1. api change, user provide name instead of idx.
  2. adjust unit tests
  3. now pytorch embedding_layer_name has changed from Class-Number to class_number.

How embedding_layer_name looks different between pytorch and paddle?

  1. paddle has built-in layer _full_name, while pytorch not. Paddle layer name starts from 0, in pytorch we start from 1
  2. paddle [layer_name]_[idx], the idx increase 1 with respect to the same layer_name, e.g. linear_0, relu_0, linear_1, while pytroch looks like this: linear_1, relu_2, linear_3.

@hanxiao hanxiao merged commit 91587d8 into main Oct 5, 2021
@hanxiao hanxiao deleted the refactor-tailor branch October 5, 2021 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants