Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon + No.224】 + 提交作品 #5

Merged
merged 18 commits into from
May 10, 2023
Merged

Conversation

SOVLOOKUP
Copy link
Contributor

@SOVLOOKUP SOVLOOKUP commented Mar 11, 2023

@SOVLOOKUP SOVLOOKUP changed the title Plato 【Hackathon + No.224】 + 提交作品 Mar 11, 2023
.vscode/settings.json Outdated Show resolved Hide resolved
src/plato-mini/.pdm.toml Outdated Show resolved Hide resolved
src/plato-mini/.vscode/settings.json Outdated Show resolved Hide resolved
src/plato-mini/src/plato_executor/config.yml Outdated Show resolved Hide resolved
src/plato-mini/src/plato_executor/executor.py Show resolved Hide resolved
Comment on lines +50 to +54
if __name__ == "__main__":
with Deployment(uses=PlatoXLExecutor) as dep:
response_docs = dep.post(
on='/', inputs=DocumentArray([Document(text='你好!')]))
print(f'Text: {response_docs[0].text}')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest converting this example into unittest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output of plato is not the same every time it runs, so unittest is not suitable here

src/plato-mini/README.md Outdated Show resolved Hide resolved
src/plato-mini/README.md Outdated Show resolved Hide resolved
@numb3r3
Copy link
Member

numb3r3 commented Mar 28, 2023

@SOVLOOKUP Please keep it in mind to push your executor to jina hub.

SOVLOOKUP and others added 4 commits March 30, 2023 22:11
Co-authored-by: felix-wang <35718120+numb3r3@users.noreply.github.com>
@SOVLOOKUP SOVLOOKUP requested a review from numb3r3 April 2, 2023 15:44
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit b0999ff into jina-ai:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants