-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation): add OpenTelemetry tracing and metrics with basic configurations #5175
Merged
Merged
Changes from all commits
Commits
Show all changes
90 commits
Select commit
Hold shift + click to select a range
a5a7f42
feat(instrumentation): create basic tracer and meter with console exp…
9e1b2d0
style: fix overload and cli autocomplete
jina-bot 514792a
feat(instrumentation): move the instrumentation package to the serve …
c3b0c37
feat(instrumentation): provide options to enable tracing and metrics …
2269b57
feat(instrumentation): add the correct grpc opentelmetery insturmenta…
14cb744
feat(serve): instrument grpc server and channel with interceptors
f53be22
style: fix overload and cli autocomplete
jina-bot a4a4621
feat(instrumentation): provide opentelemety context from the grpc cli…
78efb44
feat(instrumentation): check for opentelemetry environment variables …
7116e9f
feat(instrumentation): create InstrumentationMixin for server and cli…
92d3679
chore(instrumentation): use absolute module import
eb0ccd3
feat(instrumentation): trace http and websocket server and clients
38cae61
chore(instrumentation): update/add new opentelemetry arguments
45d1794
feat(instrumentation): globally disable tracing health check requests
b107f80
feat(instrumentation): add InstrumentationMixIn for Head and Worker r…
cd17588
feat(instrumentation): disable tracing of ServerReflection and endpoi…
2e44270
test(instrumentation): add basic tracing and metrics tests for HTTP G…
a083146
test(instrumentation): move test common code for tracing and metrics …
30ee9e3
feat(instrumentation): enable tracing of flow internal and start up r…
3998e2f
test(instrumentation): move test common code to new base class
30409c2
test(instrumentation): test grpc gateway opentelemety instrumentation
e2ee862
feat(instrumentation): add Jaeger export agent and required configura…
a0bfaf8
chore(instrumentation): remove print statement
60be044
test(instrumentation): document spans in the grpc and http gateway in…
9da9eaf
Merge branch 'master' into feat-instrumentation-5155
adb96ba
style: fix overload and cli autocomplete
jina-bot 0af8ffb
chore: remove print statement
a241f62
test(instrumentation): add instrumentaiton tests for websocket gateway
528e38b
fix: import openetelmetry api globally and the other dependencies onl…
47ed0a8
fix: use class name as default name when creating Executor instrument…
3f436da
fix: provide argparse arguments to AlternativeGateway
578e882
style: fix overload and cli autocomplete
jina-bot aa5a34a
style: fix overload and cli autocomplete
87c15f5
Merge branch 'master' into feat-instrumentation-5155
f7b4af4
style: fix overload and cli autocomplete
jina-bot 3a2e1de
style: fix overload and cli autocomplete
82dad9c
style: fix overload and cli autocomplete
jina-bot 42d00e6
fix: revert changes for Gateway implementation
9ade3b6
Merge branch 'master' into feat-instrumentation-5155
4132396
feat(instrumentation): remove init method from InstrumentationMixin
4efbbd7
feat(instrumentation): create vendor neutral opentelemetry export arg…
8e9abcb
style: fix overload and cli autocomplete
8eed211
feat(instrumentation): inject tracing variables from AsyncLoopRuntime…
175a399
style: fix overload and cli autocomplete
jina-bot 030b980
feat(instrumentation): configure a OTLP collector for exporting trace…
c686498
style: fix overload and cli autocomplete
jina-bot 6d21a3a
feat(instrumentation): return None for aio server interceptors if tra…
00c6c12
test: fix handling of optional args
92c0e1f
Merge branch 'master' into feat-instrumentation-5155
6e27829
fix: remove print debug statement
366a20e
fix: fix gateway class loading
alaeddine-13 822b541
Merge branch 'feat-instrumentation-5155' of github.com:jina-ai/jina i…
alaeddine-13 963b82d
feat(instrumentation): fix BaseGateway telemetry dependency injection
6433930
fix: fix WebsocketGateway loading
alaeddine-13 ffadb73
fix(instrumentation): correctly handle default executor runtime_args
3f6eeff
test(instrumentation): add integration tests for grpc, http and webso…
6b35909
test(instrumentation): parameterize instrumentation tests
2906369
test(instrumentation): remove outdated tests replaced by parametrized…
f1ad7a2
fix(instrumentation): fix executor instrumentation setup
d7bb8d9
fix(instrumentation): force spawn process when running flows in param…
5e31dca
feat(instrumentation): omit opentelemetry from cli args
c23f30a
style: fix overload and cli autocomplete
jina-bot bcc39a8
test: small test refactoring
JoanFM c540628
Merge branch 'master' into feat-instrumentation-5155
2ce9c67
style: fix overload and cli autocomplete
adcb457
style: fix overload and cli autocomplete
jina-bot 0ae5f99
Merge branch 'master' into feat-instrumentation-5155
b45de43
test: dont set multiprocessing start method to spawn
bbd2fb8
fix: hide opentelemetry imports
222cfb9
Merge branch 'master' into feat-instrumentation-5155
JoanFM dcf7296
fix(runtimes): shutdown instrumentation exporters during teardown
57be55e
test: spawn processes by default in tests
7266abc
Merge branch 'feat-instrumentation-5155' of github.com:jina-ai/jina i…
e9e78ae
fix: provide client and server interceptors only when tracing is ena…
3656afc
Merge branch 'master' into feat-instrumentation-5155
4f83c47
fix(serve): correctly handle default instrumentation runtime_args
a9d5b1b
chore: hide opentelemetry imports under TYPE_CHECKING
a706480
test: avoid using spawn
JoanFM ef4a232
fix: add explicit type info and hide imports
1c0aedd
fix(executors): handle optional runtime_args correctly
c292234
chore: rename otel_context to tracing_context
01d543b
feat: use None instead of NoOp tracer and meter implementations
4afc51b
fix: remove unused import
70146e4
feat: add default tracing span for DataRequestHandler handle invocation
7f20c06
test: add test case to verify exception recording in a span
550a975
fix: use continue_on_error instead of try-except-pass
b644004
Merge branch 'master' into feat-instrumentation-5155
girishc13 d55d86c
chore: rename method name to match returning a list
132a932
fix: rename span_exporter args to traces_exporter
bb0b003
style: fix overload and cli autocomplete
jina-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the sentence. Isn't it going to overlap with the
monitoring
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my intention is to use the same terms as OpenTelemetry. If people read the OpenTelemetry documentation then the terms are aligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be renamed to
traces_exporter_host
?