fix: fix start timer before getting data lock #6071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/S
area/core
JoanFM
force-pushed
the
fix-dynamic-batching-timeout
branch
from
ad98d69
to
d3d58b2
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6071 +/- ##
==========================================
- Coverage 76.86% 76.67% -0.20%
==========================================
Files 145 145
Lines 13986 13989 +3
==========================================
- Hits 10751 10726 -25
- Misses 3235 3263 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
JoanFM
force-pushed
the
fix-dynamic-batching-timeout
branch
from
d3d58b2
to
b022bdd
Compare
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
fix-dynamic-batching-timeout
branch
from
b022bdd
to
fb8071c
Compare
JohannesMessner
approved these changes
Oct 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
resolves #ISSUE-NUMBER
...
...
...
...
check and update documentation. See guide and ask the team.