Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue 6140 #6141

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: fix issue 6140 #6141

wants to merge 3 commits into from

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 16, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (073511e) 75.20% compared to head (e836848) 75.18%.
Report is 3 commits behind head on master.

Files Patch % Lines
jina/serve/runtimes/helper.py 0.00% 10 Missing ⚠️
jina/serve/runtimes/worker/request_handling.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6141      +/-   ##
==========================================
- Coverage   75.20%   75.18%   -0.02%     
==========================================
  Files         152      152              
  Lines       14062    14070       +8     
==========================================
+ Hits        10575    10579       +4     
- Misses       3487     3491       +4     
Flag Coverage Δ
jina 75.18% <8.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Feb 19, 2024
@JoanFM JoanFM force-pushed the fix-6140 branch 3 times, most recently from 4eef9ed to c9d6ce9 Compare February 19, 2024 10:10
Signed-off-by: Joan Martinez <joan.fontanals.martinez@jina.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two fields with the same type are conflicted with KeyError in pydantic
1 participant