Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expand tag tree after a SWF is added or closed #144

Closed
wants to merge 1 commit into from

Conversation

Maran23
Copy link

@Maran23 Maran23 commented Nov 8, 2022

This PR will remove the behaviour, that ALL SWFs are opened after a SWF is added or removed.
This behaviour is unfortunately annoying when working with a lot of SWFs in the tagTree as every add or remove modification will expand everything again, even though you closed all of them before.

If this is the desired behaviour, we can also add a Configuration flag for that, so users can decide whether they want this behaviour or not.
Also if desired, I can adjust this behaviour for the tagListTree and the dumpTree as well, as those two are also affected by the above described behaviour.

@jindrapetrik
Copy link
Owner

I think this should only expand the added swfs, not all existing. Am i right?

@Maran23
Copy link
Author

Maran23 commented Nov 8, 2022

I think this should only expand the added swfs, not all existing. Am i right?

The current behaviour does expand all tree nodes on a remove or add operation.

With my change, all added swfs will be added in the collapsed state, and all existing swfs will stay the same (so either expanded or collapsed - same for a remove).

This is also useful when adding multiple swfs as well as it won't clutter the tree that much as all swfs are added in the collapsed state.

@jindrapetrik
Copy link
Owner

Ok, I modified it a bit.
In nightly 2153, only newly added SWFs are expanded.
If you do not want expanding at all,
there is new Setting in Advanced settings / Interface / "Expand first level of tree on SWF load"
which can be turned off to suit your needs.

Is it okay now?

@Maran23
Copy link
Author

Maran23 commented Nov 8, 2022

Ok, I modified it a bit. In nightly 2153, only newly added SWFs are expanded. If you do not want expanding at all, there is new Setting in Advanced settings / Interface / "Expand first level of tree on SWF load" which can be turned off to suit your needs.

Is it okay now?

Yes, just checked it and looks alright.
On my local branch, I also experimented with a configuration flag for this. I think this is the best solution for all needs.
Thanks, that will help a lot!

@jindrapetrik
Copy link
Owner

You're welcome!
Also thank you for the suggestion.
I am closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants